Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add env cmd to root #2171

Merged
merged 1 commit into from
Aug 17, 2022
Merged

fix: add env cmd to root #2171

merged 1 commit into from
Aug 17, 2022

Conversation

developer-guy
Copy link
Member

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Summary

I saw that we didn't add the env cmd to root, so, this PR will fix that.

Release Note

fix: add env cmd to root

Documentation

@developer-guy developer-guy self-assigned this Aug 17, 2022
@developer-guy
Copy link
Member Author

I'm not sure whether it is intended, but anyways I'd give it a try.

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #2171 (1285d2d) into main (83c8134) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2171      +/-   ##
==========================================
- Coverage   26.62%   26.62%   -0.01%     
==========================================
  Files         130      130              
  Lines        7677     7678       +1     
==========================================
  Hits         2044     2044              
- Misses       5372     5373       +1     
  Partials      261      261              
Impacted Files Coverage Δ
cmd/cosign/cli/commands.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dlorenc dlorenc merged commit 93284d6 into sigstore:main Aug 17, 2022
@github-actions github-actions bot added this to the v1.11.0 milestone Aug 17, 2022
cldmnky pushed a commit to cldmnky/cosign that referenced this pull request Aug 21, 2022
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants